Fix nil txReceipt handling in SetOutputVarForStep #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Chris Li <chris.li.2046@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the ContractWriteProcessor by ensuring that txReceipt is only added to the output variables if it is not nil, preventing a potential nil pointer dereference.
- Introduces a local map (outputVars) to construct output variables.
- Conditionally adds txReceipt to outputVars based on a nil check.
- Updates the call to SetOutputVarForStep with the refined outputVars.
Comments suppressed due to low confidence (1)
core/taskengine/vm_runner_contract_write.go:181
- The variable 'txReceipt' is not defined in this scope; it appears you intended to check 'outputData.ContractWrite.TxReceipt'.
if txReceipt != nil {
chrisli30
approved these changes
May 10, 2025
chrisli30
added a commit
that referenced
this pull request
May 14, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
chrisli30
added a commit
that referenced
this pull request
May 21, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nil txReceipt handling in SetOutputVarForStep
Description
This PR fixes the test failure in PR #215 by properly handling nil txReceipt in the ContractWriteProcessor's SetOutputVarForStep method. The issue was that the code was trying to include txReceipt in output variables without checking if it was nil first, which could cause a nil pointer dereference.
Changes
Testing
The fix addresses the failing test TestContractWriteSimpleReturn in the core/taskengine package.
Related Issues
Fixes the test failure in PR #215: https://github.com/AvaProtocol/EigenLayer-AVS/actions/runs/14543855857/job/40806468997?pr=215
Link to Devin run
https://app.devin.ai/sessions/8fedac6730214293bcba154bf20912c2
Requested by: Chris Li (chris@avaprotocol.org)